Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging.mjs Logger to be a class #581

Closed
6 tasks done
Tracked by #50
jeromy-cannon opened this issue Sep 16, 2024 · 0 comments · Fixed by #622
Closed
6 tasks done
Tracked by #50

Update logging.mjs Logger to be a class #581

jeromy-cannon opened this issue Sep 16, 2024 · 0 comments · Fixed by #622
Assignees
Labels
P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.

Comments

@jeromy-cannon
Copy link
Contributor

jeromy-cannon commented Sep 16, 2024

  • Refactor logging.mjs so that Logger is a class with a constructor and its methods
  • update JSDoc as needed.
  • create a new class that extends Listr2's ProcessOutput
    • capture stdout and stderr buffered messages into our Logger as debug and error messages
    • capture listr2 log messages into our Logger as info messages
    • update Listr2 calls to provide the renderOptions and supply our custom ProcessOutput, see: https://listr2.kilic.dev/renderer/process-output.html
  ],
  {
    concurrent: true,
    rendererOptions: {
      logger: new ListrLogger({ processOutput: new ProcessOutput(null, null, { dump: [] }) })
    }
  }
)

await tasks.run()

This might help close out #546

@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Sep 16, 2024
@jeromy-cannon jeromy-cannon moved this from 🆕 New to 🔖 Ready in Solo Sep 16, 2024
@jeromy-cannon jeromy-cannon added the P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. label Sep 16, 2024
@jeromy-cannon jeromy-cannon moved this from 🔖 Ready to 🏗 In progress in Solo Sep 30, 2024
@jeromy-cannon jeromy-cannon moved this from 🏗 In progress to 👀 In review in Solo Sep 30, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Solo Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.
Projects
Status: ✅ Done
2 participants