Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase stability in resources/support-zip.sh #683

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • increase stability in resources/support-zip.sh

Related Issues

@jeromy-cannon jeromy-cannon self-assigned this Oct 11, 2024
Copy link
Contributor

github-actions bot commented Oct 11, 2024

Unit Test Results - Linux

  1 files  ±0   40 suites  ±0   6s ⏱️ ±0s
112 tests ±0  112 ✅ ±0  0 💤 ±0  0 ❌ ±0 
124 runs  ±0  124 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e6f1790. ± Comparison against base commit 68ef0de.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Unit Test Results - Windows

  1 files  ±0   40 suites  ±0   19s ⏱️ ±0s
112 tests ±0  112 ✅ ±0  0 💤 ±0  0 ❌ ±0 
124 runs  ±0  124 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e6f1790. ± Comparison against base commit 68ef0de.

♻️ This comment has been updated with latest results.

Copy link
Contributor

E2E Test Report

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit adfd1a4.

Copy link
Contributor

github-actions bot commented Oct 11, 2024

E2E Test Report

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit e6f1790.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Oct 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 68ef0de1
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (68ef0de) Report Missing Report Missing Report Missing
Head commit (e6f1790) 14237 9579 67.28%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#683) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.10%. Comparing base (65a1b53) to head (e6f1790).
Report is 37 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
- Coverage   69.15%   66.10%   -3.06%     
==========================================
  Files          40       38       -2     
  Lines       14560    14237     -323     
  Branches      779      931     +152     
==========================================
- Hits        10069     9411     -658     
- Misses       4444     4686     +242     
- Partials       47      140      +93     

see 24 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon marked this pull request as ready for review October 11, 2024 17:27
@jeromy-cannon jeromy-cannon requested review from leninmehedy and a team as code owners October 11, 2024 17:27
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon jeromy-cannon merged commit 33fa326 into main Oct 11, 2024
38 of 40 checks passed
@jeromy-cannon jeromy-cannon deleted the 00680-support-zip branch October 11, 2024 18:38
swirlds-automation added a commit that referenced this pull request Oct 18, 2024
## [0.31.1](v0.31.0...v0.31.1) (2024-10-18)

### Bug Fixes

* increase stability in K8 copyTo, copyFrom, and execContainer by reducing backpressure ([#684](#684)) ([2a8fc4d](2a8fc4d))
* increase stability in resources/extract-platform.sh ([#682](#682)) ([7be759d](7be759d))
* increase stability in resources/support-zip.sh ([#683](#683)) ([33fa326](33fa326))
* **tests:** fix failing test case and correct package.json test runs ([#672](#672)) ([2c39105](2c39105))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase stability in resources/support-zip.sh
3 participants