Add connectInject.prepareDataplanesUpgrade value #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set to true before performing an upgrade to a consul-dataplanes compatible consul-k8s version. This will ensure that the ACL tokens used to register non-dataplane services won't get deleted during the upgrade to dataplanes. If these ACL tokens are deleted, non-dataplane services won't be able to resolve their upstreams. During a normal non-dataplane upgrade this isn't an issue because the new injector re-registers all services using its new ACL token, but during an upgrade to dataplanes, the injector ignores all non-dataplane services and so doesn't re-register them with its latest token.
lkysow
added
the
pr/no-backport
david-yu
reviewed
Jul 7, 2023
ishustava
approved these changes
Jul 7, 2023
lkysow
force-pushed
the
lkysow/prepare-dataplanes-upgrade
branch
from
654f011 to
8ba790f
Compare
lkysow
force-pushed
the
lkysow/prepare-dataplanes-upgrade
branch
from
8ba790f to
2100938
Compare
david-yu
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set to true before performing an upgrade to a consul-dataplanes compatible consul-k8s version. This will ensure that the ACL tokens used to register non-dataplane services won't get deleted during the upgrade to dataplanes. If these ACL tokens are deleted, non-dataplane services won't be able to resolve their upstreams. During a normal non-dataplane upgrade this isn't an issue because the new injector re-registers all services using its new ACL token, but during an upgrade to dataplanes, the injector ignores all non-dataplane services and so doesn't re-register them with its latest token.
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: