Do not set securityContext on Openshift < 4.11 #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pglass
requested review from
curtbushko,
missylbytes,
a team,
johnlanda and
roncodingenthusiast
and removed request for
a team
2 tasks
pglass
commented
Jul 27, 2023
| them we avoid PSA warnings that are enabled by default. | ||
|
|
||
| We use the K8s version as a proxy for the OpenShift version because there is a | ||
| 1:1 mapping of versions. OpenShift 4.11 corresponds to K8s 1.24.x. |
There was a problem hiding this comment.
I'm not sure of a better way to check for OpenShift version. As far as we know and based on their docs (requires login 😞 ), there's a 1:1 mapping between OpenShift and Kube versions so I think this should be okay.
| OpenShift Version | Kubernetes Version |
|---|---|
| 4.9 | 1.22 |
| 4.10 | 1.23 |
| 4.11 | 1.24 |
| 4.12 | 1.25 |
| 4.13 | 1.26 |
There was a problem hiding this comment.
I am also unsure how to unit test this (without actually installing different kubectl / kube versions)
There was a problem hiding this comment.
Ah, there is helm template --kube-version.
$ helm template -h | grep kube-version
--kube-version string Kubernetes version used for Capabilities.KubeVersion
I'll add a unit test which uses --kube-version to validate this. edit: Done!
There was a problem hiding this comment.
@pglass added OpenShift versions here for future reference: hashicorp/consul#18307
pglass
force-pushed
the
pglass/NET-185/fix-psa-openshift-11x
branch
from
7b95dd1 to
eddc97e
Compare
curtbushko
approved these changes
Jul 31, 2023
pglass
pushed a commit
that referenced
this pull request
Jul 31, 2023
pglass
pushed a commit
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
release/1.1.x, and will be backported intorelease/1.0.xbecause both of those Consul K8s versions support K8s < 1.23.x and therefore support OpenShift <= 4.10How I've tested this PR:
How I expect reviewers to test this PR:
👀
Checklist: