Fix consul-telemetry-collector deployment templates #3184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
foo
arg"default"
auth login namespace that break authHow I've tested this PR:
I reproduced the behavior described by @david-yu
I did a Helm install using a template that includes
global.acls.manageSystemACLs=true
: https://github.com/jjti/consul-experiments/blob/main/telemetry-collector/helm/consul.yamlI
kubectl apply
'ed a manually created deployment (based on a fixed version of helm's output): https://github.com/jjti/consul-experiments/blame/e2da8fe2d768472b549780f8eea2cc10e7da04e4/telemetry-collector/resources/consul-telemetry-collector.yaml#L231I saw the telemetry collector start and push metrics:
I also ran the bats tests locally:
How I expect reviewers to test this PR:
Checklist: