-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add named prom port to dataplane sidecar #3222
Conversation
b08f8a5
to
fd6bd7c
Compare
@DanStough I would backport to at least 1.3.0 since right now there is no option for folks to use this feature and they will have to wait until v2 is GA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dan! Looks pretty good but I think that I may? have found a bug?
control-plane/connect-inject/webhook/consul_dataplane_sidecar.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Hamish <hamish.forbes@gmail.com>
fd6bd7c
to
08900f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* feat: add named prom port to dataplane sidecar Co-authored-by: Hamish <hamish.forbes@gmail.com> * PR Feedback --------- Co-authored-by: Hamish <hamish.forbes@gmail.com>
Changes proposed in this PR:
prometheus
to the container. This can be used for the Prometheus operator.This could easily be backported to previous versions, but I figured there was no point in the risk, considering how long this issue has been around. Let me know if anyone disagrees. I will need to do it manually to remove the V2 changes.
How I've tested this PR: unit tests
How I expect reviewers to test this PR: 👀
Checklist: