Net 10114 consul is under resourced when deploying to crc local version of open shift #4184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahalsmiller
added
backport/1.1.x
sarahalsmiller
commented
Jul 16, 2024
…loying-to-CRC-local-version-of-OpenShift
…CRC-local-version-of-OpenShift' of github.com:hashicorp/consul-k8s into NET-10114-Consul-is-under-resourced-when-deploying-to-CRC-local-version-of-OpenShift
|
do we need to do anything in code to set the defaults we previously had? |
The chart has their original values if they're not set in the values.yml. If we're overriding the resources I'm not sure if the code should try and overwrite that since we don't seem to be doing that anywhere else the resources are configurable. |
jm96441n
approved these changes
Jul 22, 2024
sarahalsmiller
deleted the
NET-10114-Consul-is-under-resourced-when-deploying-to-CRC-local-version-of-OpenShift
branch
This was referenced Jul 22, 2024
sarahalsmiller
added a commit
that referenced
this pull request
Jul 22, 2024
…on of open shift (#4184) * cert managerkubectl get pods * make resources for webhook cert manager configurable * changelog entry * Update charts/consul/values.yaml * make gateway resources configurable * update changelog
sarahalsmiller
added a commit
that referenced
this pull request
Jul 22, 2024
…on of open shift (#4184) * cert managerkubectl get pods * make resources for webhook cert manager configurable * changelog entry * Update charts/consul/values.yaml * make gateway resources configurable * update changelog
sarahalsmiller
added a commit
that referenced
this pull request
Jul 22, 2024
…on of open shift (#4184) * cert managerkubectl get pods * make resources for webhook cert manager configurable * changelog entry * Update charts/consul/values.yaml * make gateway resources configurable * update changelog
sarahalsmiller
added a commit
that referenced
this pull request
Jul 22, 2024
…n of open shift (#4184) * cert managerkubectl get pods * make resources for webhook cert manager configurable * changelog entry * Update charts/consul/values.yaml * make gateway resources configurable * update changelog
sarahalsmiller
added a commit
that referenced
this pull request
Jul 22, 2024
… local version of open shift into release/1.5.x (#4200) * backport of commit 2fecfa9 * backport of commit 640a792 * backport of commit 8ef3b40 * backport of commit a083db0 * backport of commit 0050297 * et 10114 consul is under resourced when deploying to crc local version of open shift (#4184) * cert managerkubectl get pods * make resources for webhook cert manager configurable * changelog entry * Update charts/consul/values.yaml * make gateway resources configurable * update changelog --------- Co-authored-by: Sarah Alsmiller <sarah.alsmiller@hashicorp.com> Co-authored-by: sarahalsmiller <100602640+sarahalsmiller@users.noreply.github.com>
sarahalsmiller
added a commit
that referenced
this pull request
Jul 23, 2024
… local version of open shift into release/1.1.x (#4197) * backport of commit 2fecfa9 * backport of commit 640a792 * backport of commit 8ef3b40 * backport of commit a083db0 * Net 10114 consul is under resourced when deploying to crc local version of open shift (#4184) * cert managerkubectl get pods * make resources for webhook cert manager configurable * changelog entry * Update charts/consul/values.yaml * make gateway resources configurable * update changelog --------- Co-authored-by: Sarah Alsmiller <sarah.alsmiller@hashicorp.com> Co-authored-by: sarahalsmiller <100602640+sarahalsmiller@users.noreply.github.com>
sarahalsmiller
added a commit
that referenced
this pull request
Jul 23, 2024
… local version of open shift into release/1.3.x (#4198) * backport of commit 2fecfa9 * backport of commit 640a792 * backport of commit 8ef3b40 * backport of commit a083db0 * Net 10114 consul is under resourced when deploying to crc local version of open shift (#4184) * cert managerkubectl get pods * make resources for webhook cert manager configurable * changelog entry * Update charts/consul/values.yaml * make gateway resources configurable * update changelog --------- Co-authored-by: Sarah Alsmiller <sarah.alsmiller@hashicorp.com> Co-authored-by: sarahalsmiller <100602640+sarahalsmiller@users.noreply.github.com>
sarahalsmiller
added a commit
that referenced
this pull request
Jul 23, 2024
… local version of open shift into release/1.4.x (#4199) * backport of commit 2fecfa9 * backport of commit 640a792 * backport of commit 8ef3b40 * backport of commit a083db0 * Net 10114 consul is under resourced when deploying to crc local version of open shift (#4184) * cert managerkubectl get pods * make resources for webhook cert manager configurable * changelog entry * Update charts/consul/values.yaml * make gateway resources configurable * update changelog --------- Co-authored-by: Sarah Alsmiller <sarah.alsmiller@hashicorp.com> Co-authored-by: sarahalsmiller <100602640+sarahalsmiller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
How I've tested this PR
How I expect reviewers to test this PR
Checklist