NET-10124: Add metrics endpoint and labels to sync catalog deployment #4212
Conversation
NiniOak
added
backport/1.2.x
NiniOak
requested review from
a team,
jm96441n and
wangxinyi7
and removed request for
a team
NiniOak
removed
the
pr/no-changelog
|
|
||
| if c.prometheusSink == nil { | ||
| c.logger.Error("Prometheus sink not initialized, metrics cannot be displayed") | ||
| c.prometheusSink = &prometheus.PrometheusSink{} |
There was a problem hiding this comment.
I need this to not throw a nil pointer error. Happy to remove
There was a problem hiding this comment.
will this condition ever not be nil? the default for a pointer field is nil and I don't see where we're setting this so I'd assume we always fall into this block right?
There was a problem hiding this comment.
We set this value on L522, there was was nil pointer errors in testing so I put this there, I'll remove it cos it's not a condition I see us hitting in production.
There was a problem hiding this comment.
oh nah I think it's a valid check, what I mean is there ever a case where this would actually be set? to me it seems like this will always be nil and need to be set
There was a problem hiding this comment.
No it won't be nil, recordMetrics() returns prometheus.PrometheusSink which we assign to this field. So c.prometheusSink value will only be nil if recordMetrics() returns an error(as we just log create metrics sink error and continue running feature). Let's chat if you need further explanation
NiniOak
removed
backport/1.2.x
NiniOak
added
pr/no-backport
| } | ||
|
|
||
| // authorizeMiddleware validates the token and returns http handler. | ||
| func (c *Command) authorizeMiddleware() func(http.Handler) http.Handler { |
There was a problem hiding this comment.
is this doing anything yet or is this a placeholder for when we implement auth?
There was a problem hiding this comment.
This is just a placeholder for now
control-plane/controllers/configentries/configentry_controller_test.go
Outdated
Show resolved
Hide resolved
Changes proposed in this PR
How I've tested this PR
How I expect reviewers to test this PR
Checklist