-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove all k8s services from consul #4255
Conversation
6eea669
to
0c5150d
Compare
charts/consul/templates/sync-catalog-cleanup-k8s-svc-in-consul-job.yaml
Outdated
Show resolved
Hide resolved
3c1b2df
to
4c8c7ef
Compare
4c8c7ef
to
a211357
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a few suggestions for simplifying things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good to me, well done 💯
I'll wait from an approval from @nathancoleman before merging, as he had some comments earlier
Changes proposed in this PR
consul-k8s-control-plane sync-catalog -purge-k8s-services-from-node=k8s-sync
.How I've tested this PR
consul-k8s-control-plane sync-catalog -purge-k8s-services-from-node=k8s-sync
How I expect reviewers to test this PR
Checklist