Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make log level of consul-sidecar configurable via annotations #525

Closed
paksu opened this issue May 26, 2021 · 2 comments
Closed

Make log level of consul-sidecar configurable via annotations #525

paksu opened this issue May 26, 2021 · 2 comments
Labels
type/enhancement New feature or request waiting-reply Waiting on the issue creator for a response before taking further action

Comments

@paksu
Copy link

paksu commented May 26, 2021

Is your feature request related to a problem? Please describe.

Add the ability to configure the log level of consul-sidecar containers that get injected to run in the service pods.

Feature Description

At the moment there is no way to control the log level of the side cars which might be useful since they log quite alot of things. I think the best approach here would be to just do this via the annotations, for example consul.hashicorp.com/sidecar-proxy-log-level so you can control the log level individual services.

Use Case(s)

I think this is a standard feature of pretty much every service.

Contributions

Unfortunately I don't have time.

@paksu paksu added the type/enhancement New feature or request label May 26, 2021
@david-yu
Copy link
Contributor

Hi @paksu we actually have the following annotation hashicorp.com/envoy-extra-args for adjusting log levels via annotation of Envoy. Is this what you were looking for?

In addition we did a major architecture change in Consul Kubernetes for 0.32.0 of the Helm chart and 0.26.0 of the Consul K8s binary to now handle most of the Connect logic connect webhook injector deployment. We are still planning on providing a solution for JSON logging as shown here: #523

@david-yu david-yu added the waiting-reply Waiting on the issue creator for a response before taking further action label Jun 25, 2021
@david-yu
Copy link
Contributor

david-yu commented Jul 7, 2021

Hi @paksu will close since there seems to be a way to do this today as described above. I have not heard back since replying. Please re-open if you feel that is not the case.

@david-yu david-yu closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request waiting-reply Waiting on the issue creator for a response before taking further action
Projects
None yet
Development

No branches or pull requests

2 participants