Create mesh webhook to support v2 resources #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
added
pr/no-changelog
thisisnotashwin
force-pushed
the
ashwin/NET-5320-mesh-webhook-v2
branch
4 times, most recently
from
843045b
to
8118bf8
Compare
DanStough
suggested changes
Sep 8, 2023
There was a problem hiding this comment.
Wow, lots of great work @thisisnotashwin! My only dealbreaker was using the new consul-dataplane arguments I linked to in the comments below.
One general question: Since much of this code is unchanged from the V1 Webhook, would there be less duplication if we kept everything in the same package and just had separate files/funcs for the V2 stuff? e.i. webhook.MeshWebhookV2() vs webhookV2.MeshWebhook(). We could also add this as a refactoring task after the code freeze.
control-plane/connect-inject/constants/annotations_and_labels.go
Outdated
Show resolved
Hide resolved
control-plane/connect-inject/webhook_v2/consul_dataplane_sidecar.go
Outdated
Show resolved
Hide resolved
control-plane/connect-inject/webhook_v2/consul_dataplane_sidecar.go
Outdated
Show resolved
Hide resolved
control-plane/connect-inject/webhook_v2/consul_dataplane_sidecar.go
Outdated
Show resolved
Hide resolved
thisisnotashwin
force-pushed
the
ashwin/NET-5320-mesh-webhook-v2
branch
from
422fa17
to
e2bbf16
Compare
thisisnotashwin
force-pushed
the
ashwin/NET-5320-mesh-webhook-v2
branch
from
e2bbf16
to
a5b0a1c
Compare
thisisnotashwin
force-pushed
the
ashwin/NET-5320-mesh-webhook-v2
branch
from
a5b0a1c
to
80fb3e0
Compare
DanStough
approved these changes
Sep 11, 2023
Comment on lines
561
to
567
| func (w *MeshWebhook) annotatedServiceNames(pod corev1.Pod) []string { | ||
| var annotatedSvcNames []string | ||
| if anno, ok := pod.Annotations[constants.AnnotationService]; ok { | ||
| annotatedSvcNames = strings.Split(anno, ",") | ||
| } | ||
| return annotatedSvcNames | ||
| } |
There was a problem hiding this comment.
Is this used anywhere now? I think we can deprecate it since we decouple the services.
thisisnotashwin
force-pushed
the
ashwin/NET-5320-mesh-webhook-v2
branch
from
80fb3e0
to
3b376d2
Compare
thisisnotashwin
force-pushed
the
ashwin/NET-5320-mesh-webhook-v2
branch
from
3b376d2
to
0a8bb71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: