-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Net 6529 Gatewayclassconfig CRD #3225
Conversation
5b07d3f
to
b861051
Compare
shortNames: | ||
- gateway-class-config | ||
singular: gatewayclassconfig | ||
scope: Namespaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we wanted this to be Cluster
-scoped. We just now realized this. Will you add the following annotation to the GatewayClassConfig
? // +kubebuilder:resource:scope=Cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You got it
b861051
to
1eea090
Compare
* CRD file gneration * update to cluster scope * cluster scope
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: