Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for ServiceTaggedAddresses #1398

Closed
danieleva opened this issue Jul 24, 2020 · 1 comment · Fixed by #1400
Closed

[Feature] Add support for ServiceTaggedAddresses #1398

danieleva opened this issue Jul 24, 2020 · 1 comment · Fixed by #1400
Labels
consul Related to the Consul integration enhancement
Milestone

Comments

@danieleva
Copy link
Contributor

I need to access the values published by a service in its ServiceTaggedAddresses field. I can see the value by querying consul API directly, but they are not available in consul-template.
If I understood the code correctly that is because ServiceTaggedAddresses is not parsed into the CatalogService struct in
https://github.com/hashicorp/consul-template/blob/master/dependency/catalog_service.go

Would you be interested in a PR to add that?

@eikenb
Copy link
Contributor

eikenb commented Jul 24, 2020

Hey @danieleva,

This seems like it should be a pretty simple addition and If you'd like to submit a PR I'd be happy to look at it. Please remember tests.

Thanks.

@eikenb eikenb added the consul Related to the Consul integration label Jul 28, 2020
@eikenb eikenb added this to the 0.26.0 milestone Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consul Related to the Consul integration enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants