Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done channel used before initialization #1650

Closed
eikenb opened this issue Sep 30, 2022 · 1 comment
Closed

done channel used before initialization #1650

eikenb opened this issue Sep 30, 2022 · 1 comment
Labels
Milestone

Comments

@eikenb
Copy link
Contributor

eikenb commented Sep 30, 2022

In the new Vault Token Wrapper code it reuses the runner's done channel to know when to close, but only takes the done channel to avoid a circular import issue. But the vault token watcher setup call is before the done channel gets initialized, so it is passed as a nil channel (and thus just always blocks).

Need to move the initialization of the channel above its use.

Note that this will cause gouroutine leaks on config reloads when it starts/stops a new runner.

@eikenb eikenb added the bug label Sep 30, 2022
@eikenb eikenb added this to the v0.29.4 milestone Sep 30, 2022
@eikenb
Copy link
Contributor Author

eikenb commented Sep 30, 2022

Fixed by 5d7eef8

@eikenb eikenb closed this as completed Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant