Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Allow snapshot inspect to work on internal raft snapshots directly. #10089

Merged
merged 4 commits into from
Apr 23, 2021
Merged

CLI: Allow snapshot inspect to work on internal raft snapshots directly. #10089

merged 4 commits into from
Apr 23, 2021

Conversation

banks
Copy link
Member

@banks banks commented Apr 22, 2021

As documented, this extends consul snapshot inspect to allow it to automatically detect an attempt to open an internal snapshot direct from the raft data dir on a server rather than requiring a "packaged" snapshot to be generated and downloaded.

This is often needed by operators trying to debug issues on live Consul servers.

A note is added to docs to try to clarify the difference between external, on-demand, packaged snapshot files, and internal raw raft state snapshots, and an example usage added.

image

@banks banks added this to the 1.10.0 milestone Apr 22, 2021
@banks banks requested a review from a team April 22, 2021 11:31
@github-actions github-actions bot added theme/cli Flags and documentation for the CLI interface type/docs Documentation needs to be created/updated/clarified labels Apr 22, 2021
@banks banks changed the title Snapshot inspect CLI: Allow snapshot inspect to work on internal raft snapshots directly. Apr 22, 2021
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@banks banks mentioned this pull request Apr 22, 2021
Merged
mkeeler
mkeeler approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a changelog entry added but otherwise this all looks good. Having this is going to be very useful for debugging.

@vercel vercel bot temporarily deployed to Preview – consul April 23, 2021 14:46 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 23, 2021 14:46 Inactive
banks
banks commented Apr 23, 2021
View reviewed changes
.changelog/10089.txt Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 23, 2021 15:00 Inactive
@vercel vercel bot temporarily deployed to Preview – consul April 23, 2021 15:00 Inactive
@banks banks merged commit d717d2c into master Apr 23, 2021
@banks banks deleted the snapshot-inspect branch April 23, 2021 15:17
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/355992.

@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/356924.

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit d717d2c onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Apr 23, 2021
@banks @hc-github-team-consul-core
CLI: Allow snapshot inspect to work on internal raft snapshots direct…
74c0404 
…ly. (#10089)

* CLI: Add support for reading internal raft snapshots to snapshot inspect

* Add snapshot inspect test for raw state files

* Add changelog entry

* Update .changelog/10089.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeeler mkeeler mkeeler approved these changes

Assignees
No one assigned
Labels
theme/cli Flags and documentation for the CLI interface theme/reliability type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@banks @hashicorp-ci @mkeeler