Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Update conditional for topology empty state #10124

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented Apr 26, 2021

If there are no upstreams or downstreams but the user has permissive intentions, like wildcard or default allow, then we still need to show banner and *(All Services) card, not empty state.

Before
Screen Shot 2021-04-27 at 10 00 24 AM

After
Screen Shot 2021-04-27 at 10 02 55 AM

@kaxcode kaxcode added theme/ui Anything related to the UI backport/1.10 labels Apr 26, 2021
@kaxcode kaxcode requested a review from johncowen April 26, 2021 16:39
@vercel vercel bot temporarily deployed to Preview – consul April 26, 2021 16:40 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 26, 2021 16:41 Inactive
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for chatting me through that query I had 👍

@kaxcode kaxcode merged commit 7caa47d into master Apr 28, 2021
@kaxcode kaxcode deleted the ui/bug/update-empty-state-for-topology branch April 28, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants