Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token hiding in logs sometimes has unexpected output #1020

Closed
ryanuber opened this issue Jun 10, 2015 · 1 comment
Closed

Token hiding in logs sometimes has unexpected output #1020

ryanuber opened this issue Jun 10, 2015 · 1 comment
Labels
type/bug Feature does not function as expected

Comments

@ryanuber
Copy link
Member

Only noticed on the internal endpoints so far, but I've seen this a few times in the logs:

    2015/06/10 12:30:15 [DEBUG] http: Request <hidden>/<hidden>v<hidden>1<hidden>/<hidden>i<hidden>n<hidden>t<hidden>e<hidden>r<hidden>n<hidden>a<hidden>l<hidden>/<hidden>u<hidden>i<hidden>/<hidden>s<hidden>e<hidden>r<hidden>v<hidden>i<hidden>c<hidden>e<hidden>s<hidden>?<hidden>d<hidden>c<hidden>=<hidden>d<hidden>c<hidden>1<hidden>&<hidden>t<hidden>o<hidden>k<hidden>e<hidden>n<hidden>=<hidden> (451.737µs)

Only the token at the end should be <hidden>.
@ryanuber ryanuber added the type/bug Feature does not function as expected label Jun 10, 2015
@ryanuber
Copy link
Member Author

Turns out this happened with ?token= didn't actually have a token after it.

@ekmixon ekmixon mentioned this issue Apr 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Feature does not function as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryanuber