Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Miscellaneous Lock Session fixes #10225

Merged
merged 2 commits into from
May 19, 2021
Merged

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented May 11, 2021

Whilst reviewing #9930 and #10121 we noticed a few bugs that required fixing up within Lock Sessions in the UI.

The first and most important was that the Lock Session APIs changed shape back in 1.7 but the documentation doesn't reflect this change (https://www.consul.io/api-docs/session#sample-response-3) so I've already added an issue for this here #10095

The UI still expected the JSON response to be in the pre-1.7 shape so primarily this PR alters our mock API and the UI to the shape of the response as it is post-1.7.

Also:

Viewing a Session for a KV:

  1. We noticed that the Name property is optional, so we only show this row if a Name is set for a session.
  2. We noticed that this is the only place in the UI where we refer to a Node as an 'Agent' and is probably just a hangover from the original version of the UI, so we've changed this up here to use the word Node instead to match the rest of the UI.
  3. There was a bug where we weren't showing the Delay or TTL here at all, so we fixed that here also.
  4. We changed the order of the rows in the table to match the order of the information in our Lock Session listing page.

Lock Session Listing page/component:

  1. We moved the CopyButton for the ID out of the dt and into the dd to make it visible/clickable.
  2. Upgraded the tooltips to use a modifier style which we added in ui: Modifier based tooltips #9288

@johncowen johncowen added theme/ui Anything related to the UI backport/1.9 labels May 11, 2021
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging May 13, 2021 11:01 Inactive
@vercel vercel bot temporarily deployed to Preview – consul May 13, 2021 11:01 Inactive
@johncowen johncowen marked this pull request as ready for review May 13, 2021 11:02
@johncowen johncowen requested a review from kaxcode May 13, 2021 11:02
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johncowen johncowen merged commit 3930204 into master May 19, 2021
@johncowen johncowen deleted the ui/bugfix/sessions-misc branch May 19, 2021 10:05
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/370670.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 3930204 onto release/1.10.x succeeded!

@hc-github-team-consul-core
Copy link
Collaborator

🍒❌ Cherry pick of commit 3930204 onto release/1.9.x failed! Build Log

johncowen added a commit that referenced this pull request May 19, 2021
johncowen added a commit that referenced this pull request May 24, 2021
* ui: Miscellaneous Lock Session fixes (#10225)

* Remove usage of replace which isn't available on 1.9.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants