-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Miscellaneous Lock Session fixes #10225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/370670. |
🍒✅ Cherry pick of commit 3930204 onto |
* ui: Miscellaneous Lock Session fixes (#10225) * Remove usage of replace which isn't available on 1.9.x
Whilst reviewing #9930 and #10121 we noticed a few bugs that required fixing up within Lock Sessions in the UI.
The first and most important was that the Lock Session APIs changed shape back in 1.7 but the documentation doesn't reflect this change (https://www.consul.io/api-docs/session#sample-response-3) so I've already added an issue for this here #10095
The UI still expected the JSON response to be in the pre-1.7 shape so primarily this PR alters our mock API and the UI to the shape of the response as it is post-1.7.
Also:
Viewing a Session for a KV:
Name
property is optional, so we only show this row if a Name is set for a session.Lock Session Listing page/component:
dt
and into thedd
to make it visible/clickable.