proxycfg: Ensure that endpoints for explicit upstreams in other datacenters are watched in transparent mode #10391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
reviewed
Jun 14, 2021
agent/structs/structs_oss.go
Outdated
Comment on lines
130
to
132
| func (n ServiceName) DiscoveryChainID() string { | ||
| return fmt.Sprintf("%s?dc=dc2", n.String()) | ||
| } |
There was a problem hiding this comment.
This appears to only be used by tests, so would probably be better as a function in state_test.go instead of a method on ServiceName.
There was a problem hiding this comment.
Thanks @dnephin! I've moved it to the test file and left the hardcoding of the dc and named the function appropriately since it's the only case the function is used for. Let me know if you'd prefer a different style.
ndhanushkodi
force-pushed
the
multidc-explicit
branch
from
4cd53b7
to
c517e65
Compare
ndhanushkodi
changed the title
when they're not in the seen services list of explicit and implicit upstreams within a datacenter. Co-authored-by: Freddy Vallenilla <freddy@hashicorp.com>
ndhanushkodi
force-pushed
the
multidc-explicit
branch
from
c517e65
to
9a525eb
Compare
freddygv
approved these changes
Jun 15, 2021
dnephin
approved these changes
Jun 15, 2021
dnephin
approved these changes
Jun 15, 2021
ndhanushkodi
changed the title
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/387160. |
|
🍒✅ Cherry pick of commit b8b4441 onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Jun 15, 2021
…enters are watched in transparent mode (#10391) Co-authored-by: Freddy Vallenilla <freddy@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Freddy Vallenilla freddy@hashicorp.com
Other Notes: