-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ca certificate metrics #10504
Add ca certificate metrics #10504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! I think this is looking good, but I'd like to understand the data sources for these certs a bit better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just one question/thought about using a single metric vs separate ones.
Co-authored-by: Daniel Nephin <dnephin@hashicorp.com>
683feb3
to
07fff84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/405375. |
Related to #9891
The PR is to add metrics around ca certificates. Ideally for each available certificate:
For the time being this apply to root CA certs and intermediate CA certs, for leaf certs it's more challenging as we don't keep a local copy of the certs in the agent (need to be confirmed)