Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ca certificate metrics #10504

Merged
merged 13 commits into from
Jul 7, 2021
Merged

Add ca certificate metrics #10504

merged 13 commits into from
Jul 7, 2021

Conversation

dhiaayachi
Copy link
Contributor

@dhiaayachi dhiaayachi commented Jun 25, 2021 •
edited by dnephin
Loading

Related to #9891

The PR is to add metrics around ca certificates. Ideally for each available certificate:

  • Seconds until it expire
  • Status of fetching it or creating (success/error)

For the time being this apply to root CA certs and intermediate CA certs, for leaf certs it's more challenging as we don't keep a local copy of the certs in the agent (need to be confirmed)

@vercel vercel bot temporarily deployed to Preview – consul June 25, 2021 14:07 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 25, 2021 14:07 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 25, 2021 19:49 Inactive
@vercel vercel bot temporarily deployed to Preview – consul June 25, 2021 19:49 Inactive
dnephin
dnephin reviewed Jun 25, 2021
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I think this is looking good, but I'd like to understand the data sources for these certs a bit better.

.changelog/10504.txt Outdated Show resolved Hide resolved
agent/consul/leader_connect.go Show resolved Hide resolved
agent/consul/leader_metrics.go Outdated Show resolved Hide resolved
agent/consul/leader_metrics.go Outdated Show resolved Hide resolved
agent/consul/leader_metrics.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – consul June 28, 2021 12:43 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 28, 2021 12:43 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 28, 2021 12:49 Inactive
@vercel vercel bot temporarily deployed to Preview – consul June 28, 2021 12:49 Inactive
@vercel vercel bot temporarily deployed to Preview – consul June 28, 2021 12:54 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 28, 2021 12:54 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 29, 2021 01:23 Inactive
@vercel vercel bot temporarily deployed to Preview – consul June 29, 2021 01:23 Inactive
@dhiaayachi dhiaayachi requested a review from dnephin June 29, 2021 01:36
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 29, 2021 19:36 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging June 29, 2021 19:39 Inactive
dnephin
dnephin reviewed Jul 5, 2021
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one question/thought about using a single metric vs separate ones.

agent/consul/leader_metrics.go Outdated Show resolved Hide resolved
agent/consul/leader_metrics.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 6, 2021 17:54 Inactive
@vercel vercel bot temporarily deployed to Preview – consul July 6, 2021 17:54 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 6, 2021 18:05 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 6, 2021 18:15 Inactive
@dhiaayachi dhiaayachi requested a review from dnephin July 6, 2021 18:22
dnephin
dnephin approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhiaayachi dhiaayachi merged commit 6390e91 into main Jul 7, 2021
@dhiaayachi dhiaayachi deleted the add-ca-metrics branch July 7, 2021 13:41
@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/405375.

@hc-github-team-consul-core
Copy link
Contributor

🍒❌ Cherry pick of commit 6390e91 onto release/1.10.x failed! Build Log

@hc-github-team-consul-core
Copy link
Contributor

🍒❌ Cherry pick of commit 6390e91 onto release/1.9.x failed! Build Log

@hc-github-team-consul-core
Copy link
Contributor

🍒❌ Cherry pick of commit 6390e91 onto release/1.8.x failed! Build Log

@dnephin dnephin added theme/certificates Related to creating, distributing, and rotating certificates in Consul theme/telemetry Anything related to telemetry or observability labels Jul 26, 2021
@dnephin dnephin mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
theme/certificates Related to creating, distributing, and rotating certificates in Consul theme/telemetry Anything related to telemetry or observability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhiaayachi @hc-github-team-consul-core @dnephin