Allow configuring graceful stop in testutil #10566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for adding this @s-matyukevich. We require a change log for this type of change, please add one here and I will be able to merge this change. |
dhiaayachi
added
the
waiting-reply
dhiaayachi
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
I added the missing changelog and will merge this on behalf of @s-matyukevich
Signed-off-by: Sergey Matyukevich <s.matyukevich@gmail.com>
dhiaayachi
force-pushed
the
testutil-gracefull-stop
branch
from
8035cf9
to
0eb1ccb
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/441551. |
github-actions
bot
removed
the
waiting-reply
|
Thank you @s-matyukevich for adding this!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR it wasn't possible to configure graceful consul shutdown in testutil. this code was always triggered.
Now the default behavior is exactly the same as it used to be, but the users are able to set SkipLeaveOnInt flag, which causes consul to actually do the graceful shutdown on receiving SIGINT, and StopTimeout flag, which allows configuring for how long we are going to wait before sending
syscall.SIGABRTto consul