ui: Split up the socket mode from the socket path

[kaxcode]

When there is no LocalBindSocketMode:

With a LocalBindSocketMode:

[johncowen]

Looking at the screengrab things look a little out to me, not sure what's going on there?

[kaxcode]

Looking at the screengrab things look a little out to me, not sure what's going on there?

Yea, I'm not sure. I'm not making any changes to spacing in this PR though. @johncowen

[kaxcode]

@johncowen fixed the issue and update the screenshot.

[johncowen]

Thanks for sorting that issue and adding the updated screengrab.

I've added another couple of tiny comments.

Apart from that, I'm ok for you to look at the spacing here or in another PR. It's completely up to you, but from what I remember back when the team decided to squash commits for PRs, it was so we don't end up adding lots of tiny commits to the git history that probably weren't relevant to folks. I think it's handy for everything to go in under the same meaningful change/changelog but either way here I think is fine.

I wrote some docs on how to style these things here https://consul-ui-staging-hashicorp.vercel.app/ui/docs/components/horizontal-kv-list if it helps, if you hit any problems doing that let me know, I'd be happy to go through together.

[johncowen]

Can't see my last comment in the Conversation view, I tried un-resolving it but that didn't effect anything, here's a link to it instead

https://github.com/hashicorp/consul/pull/10581/files#r673248452

🤞 it shows up in the Convo

[johncowen]

Awesome, I think this looks great! I think the only thing that may help this PR now would be to make another edit to the description to add a new screengrab to show how we finished it up.

Other than that LGTM!

[hc-github-team-consul-core]

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/425533.

[hc-github-team-consul-core]

🍒✅ Cherry pick of commit ab6a675 onto release/1.10.x succeeded!