ui: Show the correct 'ACLs Disabled' page when ACLs are disabled #10604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 13, 2021 11:39
1. When ACLs are disabled I can access the 'please enable ACLs' page 2. When ACLs are enabled, its the same as canRead
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/409080. |
|
🍒✅ Cherry pick of commit 54f0cd8 onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ACLs disabled:
Before:
After:
Fixes #10591
Extra note here. Out testing mostly runs everything with ACLs enabled, so we had to do a little bit of gymnastics to disable ACLs just for this test, which is also related to work going on elsewhere, got me thinking we might want to shuffle this around a little at some point. Not an urgent thing in the slightest, it's been fine for a number of years and has held up pretty well, but seeing as its a good few years old now and we have a better picture it could be an area we might want to tweak at some point.