Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: strip local ACL tokens from RPCs during forwarding if crossing datacenters #11099

Merged
merged 4 commits into from
Sep 22, 2021
Merged

grpc: strip local ACL tokens from RPCs during forwarding if crossing datacenters #11099

merged 4 commits into from
Sep 22, 2021

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Sep 21, 2021

Fixes #11086

@rboyer rboyer requested a review from a team September 21, 2021 18:57
@rboyer rboyer self-assigned this Sep 21, 2021
@vercel vercel bot temporarily deployed to Preview – consul September 21, 2021 18:59 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging September 21, 2021 18:59 Inactive
@vercel vercel bot temporarily deployed to Preview – consul September 21, 2021 19:58 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging September 21, 2021 19:58 Inactive
@vercel vercel bot temporarily deployed to Preview – consul September 21, 2021 21:04 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging September 21, 2021 21:04 Inactive
@rboyer rboyer merged commit 706fc8b into main Sep 22, 2021
@rboyer rboyer deleted the grpc-local-token-fix branch September 22, 2021 18:14
@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/454140.

@hc-github-team-consul-core
Copy link
Contributor

🍒❌ Cherry pick of commit 706fc8b onto release/1.10.x failed! Build Log

@rboyer rboyer mentioned this pull request Sep 22, 2021
Merged
rboyer added a commit that referenced this pull request Sep 22, 2021
@rboyer
grpc: strip local ACL tokens from RPCs during forwarding if crossing …
6c0a356 
…datacenters

backport of #11099 to `release/1.10.x`

Conflicts:
- agent/consul/rpc.go: this needed a lot of work just because there is
  no concept of leader forwarding for gRPC in 1.10.x
- agent/consul/subscribe_backend.go
- proto/pbcommon/common.go
rboyer added a commit that referenced this pull request Sep 23, 2021
@rboyer
[1.10.x] grpc: strip local ACL tokens from RPCs during forwarding if …
9d6155f 
…crossing datacenters (#11124)

backport of #11099 to `release/1.10.x`

Conflicts:
- agent/consul/rpc.go: this needed a lot of work just because there is
  no concept of leader forwarding for gRPC in 1.10.x
- agent/consul/subscribe_backend.go
- proto/pbcommon/common.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyhavlov kyhavlov kyhavlov approved these changes

Assignees

@rboyer rboyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grpc: strip local ACL tokens from RPCs during forwarding if crossing datacenters
4 participants
@rboyer @hc-github-team-consul-core @kyhavlov @mikemorris