-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checks: populate interval and timeout when registering services #11138
Conversation
/cc @ishustava @lkysow @pglass - I think this should fix the issue based on the earlier thread. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me @eculver (Sorry for the months-late review!)
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/590068. |
🍒✅ Cherry pick of commit 602e08a onto |
In #10707, we added
Interval
andTimeout
to the response for health checks. This uncovered a few bugs whereby we weren't properly setting these values when services get registered and their checks created through other code paths. In particular, there are no fewer than 6 places where checks can get registered for a service. This addresses the path taken via the/v1/agent/service/register
endpoint and theconsul services register
command.Here's how I tested:
Then validate that the
Interval
andTimeout
fields get populated:I also tested via the CLI by writing a
services.json
:And registering via the CLI:
Then reading the output again via the API: