-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update raft to v1.3.2 #11375
update raft to v1.3.2 #11375
Conversation
.changelog/11375.txt
Outdated
@@ -0,0 +1,3 @@ | |||
```release-note:enhancement | |||
update raft library to v1.3.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an enhancement or a bug fix?
I guess the changelog should talk about the issue that was fixed? Something about server leave not triggering an election?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I was not sure if this need to be mentioned in Consul or Raft, But since we don't really ship a changelog with raft we should add it in here.
Also the raft version have other fixes. So I'm not sure how to mention those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't expect much impact to users for the other changes I think we can omit them. We only really need to include behavioural changes that users may notice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the changelog accordingly
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/481116. |
🍒✅ Cherry pick of commit ab31c50 onto |
* update raft to v1.3.2 * add changelog * fix changelog
This update raft to v1.3.2 to partially fix #10970