Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command/redirect_traffic: Redirect DNS requests to Consul if -consul-dns-ip is passed in #11480

Merged
merged 4 commits into from
Nov 10, 2021
Merged

command/redirect_traffic: Redirect DNS requests to Consul if -consul-dns-ip is passed in #11480

merged 4 commits into from
Nov 10, 2021

Conversation

ndhanushkodi
Copy link
Contributor

@ndhanushkodi ndhanushkodi commented Nov 3, 2021 •
edited by thisisnotashwin
Loading

Redirect DNS requests to Consul if -consul-dns-ip is passed in.

@github-actions github-actions bot added the theme/cli Flags and documentation for the CLI interface label Nov 3, 2021
@ndhanushkodi ndhanushkodi mentioned this pull request Nov 3, 2021
Merged
2 tasks
@vercel vercel bot temporarily deployed to Preview – consul November 9, 2021 15:50 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging November 9, 2021 15:50 Inactive
@ndhanushkodi @thisisnotashwin
command/redirect_traffic: add rules to redirect DNS to Consul.
1f817b4 
currently uses a hack to get the consul dns service ip, and this hack
only works when the service is deployed in the same namespace as consul.
@ndhanushkodi @thisisnotashwin
command/redirect_traffic: redirect DNS to Consul when -consul-dns-ip …
c5d7470 
…is passed in
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging November 9, 2021 16:12 Inactive
@vercel vercel bot temporarily deployed to Preview – consul November 9, 2021 16:12 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging November 9, 2021 16:49 Inactive
@vercel vercel bot temporarily deployed to Preview – consul November 9, 2021 16:49 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging November 9, 2021 16:55 Inactive
@vercel vercel bot temporarily deployed to Preview – consul November 9, 2021 16:55 Inactive
@thisisnotashwin thisisnotashwin marked this pull request as ready for review November 9, 2021 17:00
ishustava
ishustava approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

.changelog/11480.txt Outdated Show resolved Hide resolved
command/connect/redirecttraffic/redirect_traffic.go Outdated Show resolved Hide resolved
@thisisnotashwin @ishustava
Apply suggestions from code review
8f87d98 
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging November 9, 2021 21:06 Inactive
@vercel vercel bot temporarily deployed to Preview – consul November 9, 2021 21:06 Inactive
@thisisnotashwin thisisnotashwin merged commit 139c4eb into main Nov 10, 2021
@thisisnotashwin thisisnotashwin deleted the dns-redirect-to-consul branch November 10, 2021 14:10
@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/498982.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishustava ishustava ishustava approved these changes

@freddygv freddygv Awaiting requested review from freddygv

Assignees
No one assigned
Labels
theme/cli Flags and documentation for the CLI interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ndhanushkodi @hc-github-team-consul-core @ishustava @thisisnotashwin