-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support auth methods for the vault connect CA provider #11573
Conversation
828164a
to
3c1eb44
Compare
3c1eb44
to
e4e4ec2
Compare
273ffa3
to
90f4968
Compare
4fab139
to
cff1b8a
Compare
6da44e4
to
8c5b111
Compare
8c5b111
to
a729a68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a document perspective. We just need to remove the 2nd warning box 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @ishustava !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM overall! 🚀
If you had time, I think it be worth having some validation of the auth method (ie this is supported, this is not) from the vault CA provider side but other than that no other concerns!
Thanks for being open to some of my feedback 💯 !!
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/505952. |
Changes proposed
Notes