ui: Add Service.Namespace variable to dashboard URL templates
#11640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
added
type/bug
evrowe
approved these changes
Nov 24, 2021
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/509163. |
johncowen
added a commit
that referenced
this pull request
Nov 25, 2021
We currently allow only Datacenter, Service.Name, this PR adds Service.Namespace.
johncowen
added a commit
that referenced
this pull request
Nov 25, 2021
We currently allow only Datacenter, Service.Name, this PR adds Service.Namespace.
johncowen
added a commit
that referenced
this pull request
Nov 25, 2021
We currently allow only Datacenter, Service.Name, this PR adds Service.Namespace.
johncowen
added a commit
that referenced
this pull request
Nov 30, 2021
…) (#11651) We currently allow only Datacenter, Service.Name, this PR adds Service.Namespace.
johncowen
added a commit
that referenced
this pull request
Nov 30, 2021
…) (#11652) We currently allow only Datacenter, Service.Name, this PR adds Service.Namespace.
johncowen
added a commit
that referenced
this pull request
Nov 30, 2021
…) (#11653) We currently allow only Datacenter, Service.Name, this PR adds Service.Namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.consul.io/docs/connect/observability/ui-visualization#configuring-dashboard-urls
Allows only
Datacenter,Service.Name(as before) this PR addsService.Namespace.I've added backport labels here but pretty sure 1.9 and 1.8 will have to be manual.
P.S. There needs to be a follow up after the backports are done to add
Partitionhere for 1.11 also.