ui: Fix URL params decoding #11931
Merged
ui: Fix URL params decoding #11931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jan 4, 2022
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/538867. |
|
🍒✅ Cherry pick of commit f8b336b onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Jan 4, 2022
* ui: Move wildcard param decoding to routlet service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.11.0/1 we moved our routing to use our Routlets almost entirely, but we missed moving the extra URL decoding for Ember Wildcard routes over to our routlet code that deals with URL params 😿 (Ember does not urlencode/urldecode wildcard routes by default)
This PR moves the code from our base Route (which all of our routes inherit from) over to our Routlet Service via a
normalizeParamsFormethod, which we then call from both our base Route and the Routlet Service. Whilst we barely use Ember Routes anymore, I left the required decoding in our base Route just incase it's required in future.I'm a little surprised we had no acceptance test for this, so this fixes an unfortunate regression in 1.11.0/1 plus adds an acceptance test which would have caught this (and will catch it if it ever happens again)
Fixes #11925
Small note here: If we ever want this to be non-project specific we'll have to decide on how to inject the project specific routes into the routlet service, for the moment we simply
import