Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make systemd EnvironmentFile optional #12176

Merged
merged 4 commits into from
Jan 24, 2022
Merged

Conversation

mdeggies
Copy link
Member

@mdeggies mdeggies commented Jan 24, 2022

Folks should be able to start/stop the service for linux packages even when the [optional] EnvironmentFile does not exist. This PR makes that possible- big thanks to @blake for this one!

Relevant snippet from the docs:

The argument passed should be an absolute filename or wildcard expression, optionally prefixed with "-", which indicates that if the file does not exist, it will not be read and no error or warning message is logged. This option may be specified more than once in which case all specified files are read. If the empty string is assigned to this option, the list of file to read is reset, all prior assignments have no effect.

Relates to #11943

@mdeggies mdeggies requested a review from blake January 24, 2022 20:19
@mdeggies mdeggies added backport/1.11 pr/no-changelog PR does not need a corresponding .changelog entry labels Jan 24, 2022
@mdeggies mdeggies removed the pr/no-changelog PR does not need a corresponding .changelog entry label Jan 24, 2022
@vercel vercel bot temporarily deployed to Preview – consul January 24, 2022 20:32 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging January 24, 2022 20:32 Inactive
@mdeggies mdeggies merged commit d2f3665 into main Jan 24, 2022
@mdeggies mdeggies deleted the make-systemd-envfile-optional branch January 24, 2022 20:47
@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/564277.

@hc-github-team-consul-core
Copy link
Contributor

🍒✅ Cherry pick of commit d2f3665 onto release/1.11.x succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants