Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile UI assets into the Consul binary #1220

Closed
armon opened this issue Sep 6, 2015 · 4 comments
Closed

Compile UI assets into the Consul binary #1220

armon opened this issue Sep 6, 2015 · 4 comments
Labels
type/enhancement Proposed improvement or new feature

Comments

@armon
Copy link
Member

armon commented Sep 6, 2015

We can use (https://github.com/jteeuwen/go-bindata) to compile the UI assets into the binary. We should still support the -ui-dir option, but now we can just have a -ui flag to enable the compiled in version. This makes distributing even simpler.

@armon armon added the type/enhancement Proposed improvement or new feature label Sep 6, 2015
@rgl
Copy link

rgl commented Oct 4, 2015

I would like to get my feet wet on consul, and this seems like a good place to start. Any recommendation on how do you want this implemented?

The current code is using http.FileServer so its natural to use https://github.com/elazarl/go-bindata-assetfs (instead of directly using go-bindata) because it already provides an adapter for http.FileServer.

@rgl
Copy link

rgl commented Oct 6, 2015

The PR is still missing the dependencies on https://github.com/jteeuwen/go-bindata and https://github.com/elazarl/go-bindata-assetfs; also, the travis build file needs to be changed to install the bundler gem and install the needed Web UI dependencies... I'm not really sure how to do these... so help me out!

@rgl
Copy link

rgl commented Oct 7, 2015

The PR is now ready to merge, I think.

@slackpad
Copy link
Contributor

This was done under #1543.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Proposed improvement or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants