-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delete folder button to web UI #124
Conversation
There seems to be a issue when deleting a child tree:
will remove |
Hm, this API call:
will remove everything below |
@tiwilliam The "folder" view is just imposed by the UI. There is no actual folder structure. So if the only key is "1/2/3/4" and that key is removed, then those "folders" also are removed. Does that make sense? |
Alright, will re-work this to make sense. |
@armon Thanks for explaining! This should now work as expected and redirect to nearest existing parent on delete or pop back to root if needed. |
Great! I would say we should do a I also noticed we're not actually rendering the |
Rebased against master. Yeah, hidden sounds like a better idea, leaving it at |
Great, merging. |
Add delete folder button to web UI
This will add a
Delete folder
button to all folders, it will be disabled for the root folder. The delete request passes?recurse
and will delete all underlying keys and folders. It might be a good idea to add a confirm dialog for this action in the future.Resolves issue #102.