Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable hostnames from telemetry #1284

Merged
merged 1 commit into from
Feb 7, 2016
Merged

Option to disable hostnames from telemetry #1284

merged 1 commit into from
Feb 7, 2016

Conversation

nbrownus
Copy link
Contributor

@nbrownus nbrownus commented Oct 8, 2015

This fixes #1241

@scalp42
Copy link
Contributor

scalp42 commented Oct 8, 2015

Thanks a lot @nbrownus 👍

@scalp42
Copy link
Contributor

scalp42 commented Nov 3, 2015

Any chance to look at this @slackpad following @nbrownus PR ? Would be greatly appreciated.

@slackpad slackpad self-assigned this Nov 16, 2015
@slackpad
Copy link
Contributor

Hi @nbrownus - thanks for this! Once we get 0.6 rolled out I'll work with you to review this so we can get it into the following release.

@slackpad slackpad added the type/enhancement Proposed improvement or new feature label Jan 8, 2016
@BRMatt
Copy link

BRMatt commented Jan 26, 2016

@slackpad Aside from the merge conflict, is there anything stopping this PR from being merged? I have some time this week and could having a shot at rebasing it if @nbrownus is busy.

@nbrownus
Copy link
Contributor Author

Rebased, dogstatsd config merged in.

@scalp42
Copy link
Contributor

scalp42 commented Jan 30, 2016

thanks a lot again @nbrownus much appreciated

@BRMatt
Copy link

BRMatt commented Feb 1, 2016

Thanks @nbrownus! ❤️

slackpad added a commit that referenced this pull request Feb 7, 2016
@slackpad
Merge pull request #1284 from nbrownus/telemetry
d60be51 
Option to disable hostnames from telemetry
@slackpad slackpad merged commit d60be51 into hashicorp:master Feb 7, 2016
@slackpad
Copy link
Contributor

slackpad commented Feb 7, 2016

Thanks for the PR - looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@slackpad slackpad

Labels
type/enhancement Proposed improvement or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telemetry including host in the metric name
4 participants
@nbrownus @scalp42 @slackpad @BRMatt