Allow specifying Consul token in an HTTP request header #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for an X-Consul-Token HTTP request header to specify the token with which this request should be fulfilled. The header would have precedence over the responding Agent's default token, but would have lower precedence than a token specified in the query string.
|
This looks great to me. Good test and doc as well. Only thing you might want to include in the doc, though it's a corner case, is explanation of what happens if both are specified but inconsistent (header wins). Any reason not to include this support, hashifolks? |
|
I tried to explain it in the doc changes, although it may be unclear. For this patch, the querystring |
|
Yeah, I'm an idiot. Read right over that. Doc looks good. |
armon
added a commit
that referenced
this pull request
Oct 22, 2015
Allow specifying Consul token in an HTTP request header
|
LGTM! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be able to pass the Consul authorization token via HTTP request header as well as through the querystring, for a couple of reasons related to setting up the Consul web UI and/or a general API gateway:
One, for security. Consul itself filters out tokens from its own request logs, but when behind a reverse proxy, that's another layer were tokens need to be filtered from logs.
Two, also for reverse proxy, adding values to the query string when dealing with OAuth or CAS-type authentication is often problematic. This would allow me to set the token I want to pass as a request header and avoid the complications.
I've also provided tests and documentation updates.