Fix #1316: Safari 403 error on k/v page of web UI #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the token argument to formatURL is null, it should be rendered as the empty string and not the string 'null'. Should fix #1316 in which Safari gets a 403 error when visiting the key/value page in the web UI.
|
Cool, thanks. |
ryanbreen
added a commit
that referenced
this pull request
Oct 20, 2015
Fix #1316: Safari 403 error on k/v page of web UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason, Safari is passing
nullas the value fortokento theformatURLfunction when displaying the key-value page. When the null value is force-converted to a string, it becomes"null", which then fails to pass ACL security tests (unless there actually is an ACL with a token of"null").This converts any
nullvaluetokento the empty string instead, which will then render correctly.Should fix #1316.