Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for viewing/editing raft/peers.json? #1417

Closed
msabramo opened this issue Nov 16, 2015 · 4 comments · Fixed by #2312
Closed

Add command for viewing/editing raft/peers.json? #1417

msabramo opened this issue Nov 16, 2015 · 4 comments · Fixed by #2312
Labels
type/enhancement Proposed improvement or new feature

Comments

@msabramo
Copy link

It occurred to me while writing an internal runbook for Consul that one thing I feel is important to check is the raft/peers.json file.

E.g.: I often end up doing:

cat /opt/consul/data/raft/peers.json

and if I were to find that this file contained null in it, then I would probably want to edit it and add back in my nodes.

Should there be some tooling around this, so it's not quite as manual?

@slackpad slackpad added the type/enhancement Proposed improvement or new feature label Jan 9, 2016
@slackpad
Copy link
Contributor

slackpad commented Jan 9, 2016

This is related to #1374.

@CpuID
Copy link

CpuID commented Apr 20, 2016

Big +1

@CpuID
Copy link

CpuID commented Jun 9, 2016

One thing to consider here - should manipulating the raft peers.json be a local operation? or a cluster wide operation? For example, removing a stale node, should such a remove command be executed on all relevant nodes individually?

@slackpad
Copy link
Contributor

We've got the most common operation covered now where you can remove a stale peer without messing with peers.json at all. For recovery during an outage where there's no longer a leader, it'll require some more work to support that case, but the consul operator command provides a good framework to add more functionality in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Proposed improvement or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants