Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please print logging about the domain the DNS is handling queries for. #1528

Closed
c4milo opened this issue Dec 18, 2015 · 3 comments
Closed

Please print logging about the domain the DNS is handling queries for. #1528

c4milo opened this issue Dec 18, 2015 · 3 comments
Labels
theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature

Comments

@c4milo
Copy link
Contributor

c4milo commented Dec 18, 2015

We just spent a couple of hours chasing down an issue with DNS resolution on Consul clients, to realize later on that we were missing the custom domain configuration on them. If logging would have printed out that information upon agent startup, it would have taken minutes instead to find the culprit.

@slackpad
Copy link
Contributor

Hi @c4milo sorry about the confusion on this one. I took a look through the DNS mux code and it doesn't look like it exposes a way to hook the default "failed" handler - it's all handled by the library and Consul doesn't see it. That's why there's no debug log output for this case. We can summarize that part of the config at startup though, along with the port information most likely.

@c4milo
Copy link
Contributor Author

c4milo commented Dec 19, 2015

It's ok, having the information logged upon startup will do it. Thanks for looking into this @slackpad!

@slackpad slackpad added easy type/enhancement Proposed improvement or new feature labels May 12, 2017
@slackpad slackpad added theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner and removed easy labels May 25, 2017
@slackpad
Copy link
Contributor

slackpad commented Jan 5, 2018

Hi, this never made it on the roadmap, and it's not a very high priority for us. We would gladly review a PR for this functionality, but we are going to close this issue since it's not something we are going to implement ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests

2 participants