Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add provider ca support for jwt file base auth #16266

Merged
merged 7 commits into from
Mar 2, 2023
Merged

add provider ca support for jwt file base auth #16266

merged 7 commits into from
Mar 2, 2023

Conversation

eikenb
Copy link
Contributor

@eikenb eikenb commented Feb 15, 2023 •
edited
Loading

Adds support for a jwt token in a file. Simply reads the file and sends the read in jwt token along to the vault login.

PR Checklist

@eikenb eikenb added type/enhancement Proposed improvement or new feature theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/consul-vault Relating to Consul & Vault interactions labels Feb 15, 2023
@eikenb eikenb force-pushed the eikenb/jwt-vault-auth-provider branch 2 times, most recently from 43f5e00 to ba5ff23 Compare February 15, 2023 05:43
@kisunji kisunji requested review from kisunji, a team and pglass and removed request for a team February 23, 2023 21:03
@eikenb eikenb force-pushed the eikenb/jwt-vault-auth-provider branch from ad90128 to daa2f34 Compare February 28, 2023 20:39
pglass
pglass approved these changes Feb 28, 2023
View reviewed changes
Copy link

@pglass pglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

agent/connect/ca/provider_vault_auth_jwt.go Outdated Show resolved Hide resolved
agent/connect/ca/provider_vault_auth_jwt.go Outdated Show resolved Hide resolved
agent/connect/ca/provider_vault_auth_test.go Outdated Show resolved Hide resolved
eikenb and others added 4 commits February 28, 2023 16:16
@eikenb
add provider ca support for jwt file base auth
350a3ca 
Adds support for a jwt token in a file. Simply reads the file and sends
the read in jwt along to the vault login.

It also supports a legacy mode with the jwt string being passed
directly. In which case the path is made optional.
@eikenb
add changelog entry
9983d98
@eikenb
add comments on legacy parameters support
1b24d2d
@eikenb
Update agent/connect/ca/provider_vault_auth_jwt.go
1de4147 
PR feedback.

Co-authored-by: Paul Glass <pglass@hashicorp.com>
@eikenb eikenb force-pushed the eikenb/jwt-vault-auth-provider branch from e0b4406 to 1de4147 Compare March 1, 2023 00:17
@eikenb eikenb merged commit 4211069 into main Mar 2, 2023
@eikenb eikenb deleted the eikenb/jwt-vault-auth-provider branch March 2, 2023 20:33
@p-linnane p-linnane mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisunji kisunji kisunji approved these changes

@pglass pglass pglass approved these changes

Assignees
No one assigned
Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/consul-vault Relating to Consul & Vault interactions type/enhancement Proposed improvement or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eikenb @pglass @kisunji