APIGW: Update how status conditions for certificates are handled #17115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that is using the certificate
jm96441n
added
pr/no-docs
andrewstucki
suggested changes
Apr 25, 2023
refs, added tests
jm96441n
commented
Apr 25, 2023
| @@ -3625,7 +4020,7 @@ func TestAPIGatewayController(t *testing.T) { | |||
| require.NoError(t, err) | |||
| ppExpected, err := json.MarshalIndent(expectedStatus, "", " ") | |||
| require.NoError(t, err) | |||
| require.True(t, statusEqual, fmt.Sprintf("statuses are unequal: %+v != %+v", string(ppActual), string(ppExpected))) | |||
| require.True(t, statusEqual, fmt.Sprintf("statuses are unequal (actual != expected): %+v != %+v", string(ppActual), string(ppExpected))) | |||
There was a problem hiding this comment.
this was a small QoL change, I can remove it if we think it's unnecessary
andrewstucki
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
LGTM -- I do eventually want to circle back and think about whether we want to handle the Accepted status differently than we do now (since a single ResolvedRefs == False listener makes Accepted == False), but as that likely will require a decent amount of additional internal plumbing to handle appropriately, I'm cool doing it later.
4 tasks
sarahalsmiller
pushed a commit
that referenced
this pull request
Jun 22, 2023
…handled into release/1.15.x (#17170) * APIGW: Update how status conditions for certificates are handled (#17115) * Move status condition for invalid certifcate to reference the listener that is using the certificate * Fix where we set the condition status for listeners and certificate refs, added tests * Add changelog * Remove unused code from backport * Revert go mod changes --------- Co-authored-by: John Maguire <john.maguire@hashicorp.com> Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
This was referenced Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes how status conditions for invalid certifcates on listeners are reported so that the status condition is on the listener and mentions which certificate is invalid in the message.
Testing & Reproduction steps
Run unit tests
Links
N/A
PR Checklist