Manage dependencies via Godep #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embrace the future and use Go 1.6's vendor support via Godep. Go 1.5 users should `export GO15VENDOREXPERIMENT=1`
| @@ -1,12 +1,9 @@ | |||
| GOTOOLS = github.com/mitchellh/gox golang.org/x/tools/cmd/stringer \ | |||
There was a problem hiding this comment.
I think this set of things / associated target is useful for people building for the first time. These aren't built into the binary so we don't want to vendor them, but they are Go-based tools used in the build process.
There was a problem hiding this comment.
Good suggestion, readded the tools target.
|
You can probably delete the deps folder as part of this change - those will exist for their releases and we no longer need to maintain that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embrace the future and use Go 1.6's vendor support via Godep.
Go 1.5 users should
export GO15VENDOREXPERIMENT=1