-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NET-3092] JWT Verify claims handling #17452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roncodingenthusiast
added
pr/no-changelog
PR does not need a corresponding .changelog entry
pr/no-docs
PR does not include docs and should not trigger reminder for cherrypicking them.
pr/no-backport
labels
May 24, 2023
roncodingenthusiast
force-pushed
the
NET-3092-verify-claims
branch
4 times, most recently
from
May 26, 2023 16:38
f579add
to
c4bcb35
Compare
roncodingenthusiast
changed the title
WIP - [NET-3092] JWT Verify claims handling
[NET-3092] JWT Verify claims handling
May 26, 2023
roncodingenthusiast
requested review from
pglass,
a team and
eikenb
and removed request for
a team
May 26, 2023 16:38
roncodingenthusiast
force-pushed
the
NET-3092-verify-claims
branch
from
May 26, 2023 17:26
ca3d6c7
to
55190af
Compare
pglass
reviewed
May 26, 2023
pglass
reviewed
May 26, 2023
pglass
reviewed
May 26, 2023
roncodingenthusiast
force-pushed
the
NET-3092-verify-claims
branch
from
May 29, 2023 10:20
9fdd207
to
dfbea3d
Compare
pglass
reviewed
May 30, 2023
pglass
reviewed
May 30, 2023
agent/xds/testdata/rbac/empty-top-level-jwt-with-one-permission--httpfilter.golden
Outdated
Show resolved
Hide resolved
roncodingenthusiast
force-pushed
the
NET-3092-verify-claims
branch
from
May 30, 2023 16:11
c37d9e1
to
1109b1c
Compare
pglass
suggested changes
May 30, 2023
agent/xds/testdata/rbac/empty-top-level-jwt-with-one-permission--httpfilter.golden
Outdated
Show resolved
Hide resolved
pglass
approved these changes
May 30, 2023
roncodingenthusiast
removed
the
pr/no-changelog
PR does not need a corresponding .changelog entry
label
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr/no-backport
pr/no-docs
PR does not include docs and should not trigger reminder for cherrypicking them.
theme/envoy/xds
Related to Envoy support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
background info
For claim verification, we need to write the claims to validate in the RBAC policies. Example in envoy, specifying
payload_in_metadata
allows us to write data from the JWT payload toStreamInfo DynamicMetadata
(read more here)Example of what the payload will look like: option 1 in this gist https://gist.github.com/pglass/a83603b77c1497b76490abc7afd44298
The test data file contain what the envoy config will look like with the jwt token
potential todo