Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builtin/property-override Envoy Extension #17487

Merged

Conversation

zalimeni
Copy link
Member

@zalimeni zalimeni commented May 26, 2023

property-override is an extension that allows for arbitrarily patching Envoy resources based on resource matching filters. Patch operations resemble a subset of the JSON Patch spec with minor differences to facilitate patching pre-defined (protobuf) schemas.

See Envoy Extension product documentation for more details.

Note that this was developed on a feature branch and commits were squashed from multiple prior PRs.

Co-authored by @erichaberkorn and @kyhavlov.

Description

  • Add the property-override builtin Envoy Extension
  • Add golden tests covering well-known use cases

See Envoy Extension product documentation (1.16) for more details.

Links

Envoy Extensions documentation

PR Checklist

  • updated test coverage
  • external facing docs updated (covered in separate change)
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/envoy/xds Related to Envoy support labels May 26, 2023
@zalimeni zalimeni removed the theme/api Relating to the HTTP API interface label May 26, 2023
@zalimeni zalimeni force-pushed the feature/net-2768-property-override-envoy-extension-merge branch 3 times, most recently from d906e15 to da11fb3 Compare May 26, 2023 19:17
`property-override` is an extension that allows for arbitrarily
patching Envoy resources based on resource matching filters. Patch
operations resemble a subset of the JSON Patch spec with minor
differences to facilitate patching pre-defined (protobuf) schemas.

See Envoy Extension product documentation for more details.

Co-authored-by: Eric Haberkorn <eric.haberkorn@hashicorp.com>
Co-authored-by: Kyle Havlovitz <kyle@hashicorp.com>
@zalimeni zalimeni force-pushed the feature/net-2768-property-override-envoy-extension-merge branch from da11fb3 to f540db6 Compare May 26, 2023 19:34
@zalimeni zalimeni requested review from cthain and erichaberkorn May 26, 2023 19:37
@zalimeni zalimeni marked this pull request as ready for review May 26, 2023 19:37
Copy link
Contributor

@cthain cthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@zalimeni zalimeni enabled auto-merge (squash) May 26, 2023 19:46
@zalimeni zalimeni merged commit 5a46a8c into main May 26, 2023
@zalimeni zalimeni deleted the feature/net-2768-property-override-envoy-extension-merge branch May 26, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants