Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Network filters for Wasm Envoy Extension #17505

Merged
merged 2 commits into from
May 30, 2023
Merged

Enable Network filters for Wasm Envoy Extension #17505

merged 2 commits into from
May 30, 2023

Conversation

cthain
Copy link
Contributor

@cthain cthain commented May 30, 2023

Description

This PR enables the builtin/wasm Envoy extension to apply Wasm network filters for TCP services.

Testing & Reproduction steps

  • The extension unit tests have been updated to verify patching Wasm network filters.
  • Envoy golden tests have been added for Wasm network filters

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@cthain cthain added pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them. pr/no-backport labels May 30, 2023
@cthain cthain self-assigned this May 30, 2023
@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label May 30, 2023
roncodingenthusiast
roncodingenthusiast approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@roncodingenthusiast roncodingenthusiast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good again! 🎉

@cthain cthain merged commit 65b8ccd into main May 30, 2023
@cthain cthain deleted the cthain/wasm-tcp-extension branch May 30, 2023 14:17
@p-linnane p-linnane mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roncodingenthusiast roncodingenthusiast roncodingenthusiast approved these changes

@erichaberkorn erichaberkorn Awaiting requested review from erichaberkorn

@zalimeni zalimeni Awaiting requested review from zalimeni

Assignees

@cthain cthain

Labels
pr/no-backport pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them. theme/envoy/xds Related to Envoy support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cthain @roncodingenthusiast