Adds a PUT-based API for TTL checks and retains output on timeouts. #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return fmt.Sprintf("%s (no output was available before timeout)", prefix) | ||
| } | ||
|
|
||
| return fmt.Sprintf("%s (last output before timeout follows)\n\n%s", prefix, c.lastOutput) |
There was a problem hiding this comment.
If we can try to conform to one newline == one log entry, that would be ideal.
|
LGTM |
slackpad
added a commit
that referenced
this pull request
Mar 3, 2016
Adds a PUT-based API for TTL checks and retains output on timeouts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new PUT-based /v1/agent/check/update/ API that's easier to pass large output to. While we were in here, we also fixed #1784 so that when the TTL expires, operators can see the last output before the check expired.