Make sure UDP DNS responses aren't larger than allowed #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackpad
added a commit
that referenced
this pull request
Mar 9, 2016
Makes sure UDP DNS responses aren't larger than allowed.
|
Thanks! Will this make it in for 0.6.4? |
|
It should - I plan on merging it today, |
| if network != "tcp" && len(resp.Answer) > maxServiceResponses { | ||
| resp.Answer = resp.Answer[:maxServiceResponses] | ||
| if network != "tcp" { | ||
| wasTrimmed := trimAnswers(resp) |
There was a problem hiding this comment.
@slackpad Apologies for bringing up an already merged PR, but it looks like this trimming is being done regardless of the enable_truncate setting. Shouldn't d.config.EnableTruncate be checked before trimAnswers() is called?
There was a problem hiding this comment.
It's slightly confusing, but EnableTruncate only determines whether the truncate bit is set, not whether truncation happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took #1734 by @idubinskiy and made a few minor tweaks.