Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of docs: Fix ServiceDefaults example in distributed tracing into release/1.15.x #18974

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Backport of docs: Fix ServiceDefaults example in distributed tracing into release/1.15.x #18974

merged 1 commit into from
Sep 22, 2023

Conversation

blake
Copy link
Member

@blake blake commented Sep 21, 2023

Description

backport of commit 38c356c

@blake blake added type/docs Documentation needs to be created/updated/clarified pr/no-changelog PR does not need a corresponding .changelog entry labels Sep 21, 2023
@blake blake requested a review from a team as a code owner September 21, 2023 23:50
@blake blake self-assigned this Sep 21, 2023
@hc-github-team-consul-core
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@blake blake enabled auto-merge (squash) September 21, 2023 23:52
boruszak
boruszak approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Approving on behalf of consul-docs

@blake blake merged commit 1ef137d into release/1.15.x Sep 22, 2023
59 of 62 checks passed
@blake blake deleted the backports/docs/fix-servicedefaults-distributed-tracing-1.15.x branch September 22, 2023 00:10
@dlaguerta dlaguerta mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boruszak boruszak boruszak approved these changes

Assignees

@blake blake

Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blake @hc-github-team-consul-core @boruszak @ilpianista