skip_leave_on_int's default changes based on agent mode #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`skip_leave_on_int`'s behavior now changes based on whether or not the agent is acting as a client or server. Fixes: 1687
| client or a server. On agents in client-mode, this defaults to `false` and | ||
| for agents in server-mode, this defaults to `true` (i.e. Ctrl-C on a server | ||
| will keep the server in the cluster and therefore quorum, and Ctrl-C on a | ||
| client will gracefully leave). |
There was a problem hiding this comment.
I think this is worth a "prior to Consul 0.7" kind of comment with the old default.
|
LGTM - noted one thing I think we should add to the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip_leave_on_int's behavior now changes based on whether or not the agent is acting as a client or server.Fixes: #1687