[NET-5455] Allow disabling request and idle timeouts with -1 in service router and resolver #19992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndhanushkodi
commented
Dec 19, 2023
| "commonLbConfig": { | ||
| "healthyPanicThreshold": {} | ||
| }, | ||
| "connectTimeout": "25s", |
There was a problem hiding this comment.
This line shows that the service resolver connect timeout works
There was a problem hiding this comment.
This db cluster was added because it has been added as a destination on the splitter
ndhanushkodi
commented
Dec 19, 2023
agent/xds/testdata/routes/connect-proxy-with-chain-and-splitter.latest.golden
Outdated
Show resolved
Hide resolved
ndhanushkodi
changed the title
ndhanushkodi
commented
Dec 19, 2023
| "commonLbConfig": { | ||
| "healthyPanicThreshold": {} | ||
| }, | ||
| "connectTimeout": "25s", |
There was a problem hiding this comment.
ingress cases are updated in the same way that connect proxy cases are
ndhanushkodi
commented
Dec 19, 2023
| "route": { | ||
| "cluster": "big-side.default.dc1.internal.11111111-2222-3333-4444-555555555555.consul", | ||
| "idleTimeout": "0s", | ||
| "timeout": "10s" |
There was a problem hiding this comment.
Shows disabling idle timeout and positive value for request timeout
ndhanushkodi
commented
Dec 19, 2023
| "prefix": "/lil-bit-side" | ||
| }, | ||
| "route": { | ||
| "cluster": "lil-bit-side.default.dc1.internal.11111111-2222-3333-4444-555555555555.consul" |
There was a problem hiding this comment.
Shows zero values for both timeouts result in them being unset in envoy
ndhanushkodi
requested review from
hashi-derek,
a team and
zalimeni
and removed request for
a team
hashi-derek
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to disable request and idle timeouts in a service router and service resolver.
Previous Behavior:
user sets 0s or doesn’t set anything -> results in envoy defaults of 15s (requestTimeout) or 1hr (idleTimeout)
user sets >0s -> results in setting that same value in envoy
Behavior with this change:
user sets -1s -> results in setting 0s in envoy (disabling the timeout)
user sets 0s or doesn’t set anything -> result in envoy defaults of 15s or 1hr
user sets >0s -> results in setting that same value in envoy
Links
https://hashicorp.atlassian.net/browse/NET-5455
PR Checklist