NET-6945 - Replace usage of deprecated Envoy field envoy.config.core.v3.HeaderValueOption.append #20078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalimeni
approved these changes
Jan 3, 2024
Comment on lines
48
to
49
| APPEND_ACTION_OVERWRITE_IF_EXISTS_OR_ADD = 1; | ||
| APPEND_ACTION_ADD_IF_ABSENT = 2; |
There was a problem hiding this comment.
~~ Non-blocking and not a super strong opinion: Given we aren't committed to backwards compatibility yet, it might help avoid a future mismatch w/ Envoy to swap these two values so they match Envoy's cardinals, assuming we expect the enum sets to match. We did an internal enum swap previously here: #18612
…v3.HeaderValueOption.append
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing & Reproduction steps
Links
PR Checklist